Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try adding extra route to metadata server #337

Merged
merged 2 commits into from
May 26, 2024
Merged

Try adding extra route to metadata server #337

merged 2 commits into from
May 26, 2024

Conversation

illusional
Copy link

@illusional illusional commented May 26, 2024 •
edited
Loading

@illusional illusional requested a review from jmarshall May 26, 2024 22:32
jmarshall
jmarshall approved these changes May 26, 2024
View reviewed changes
Copy link

@jmarshall jmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could possibly need one for '/computeMetadata/v1/instance/service-accounts/{gsa}' too, but I think that's less likely.

@illusional illusional merged commit a9a79d2 into main May 26, 2024
@illusional illusional deleted the add-extra-sa-route branch May 26, 2024 22:35
@jmarshall jmarshall mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarshall jmarshall jmarshall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illusional @jmarshall