Add pool label to "resource requests ... are unsatisfiable" message #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pool labels are a CPG-local addition (PR #197) that are considered in select_inst_coll() so should be displayed in this error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pool labels are a CPG-local addition (added in PR #197) that are considered in
select_inst_coll()so should be displayed in this error message — unfortunately we neglected to report them in the error message at the time.I've verified that this is the only new
select_inst_coll()parameter not represented in the error message (worker_typeis also not directly printed, but it is derived within_create_jobs()from other fields rather than being a config field), and that there are no other similarly bereft error messages elsewhere.Context: https://centrepopgen.slack.com/archives/C030X7WGFCL/p1718060676098609?thread_ts=1717563218.399159&cid=C030X7WGFCL