chore: update export conditions #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello there ! The official runtime export key for cloudflare is `workerd` (not worker). I believe many apps out there might already be relying on `worker` so I propose to add it alongside it. Reference : - https://developers.cloudflare.com/workers/wrangler/bundling/#conditional-exports - https://runtime-keys.proposal.wintercg.org/#workerd
|
Read from here on down for why it was changed from workerd to worker originally. #618 (comment) Would be great to get a confirmation from cloudflare if they now think |
|
@porsager - |
|
I'll merge this and remove the worker export for now, as it appears the cases where the worker export is requested actually needs the default esm export. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there !
The official runtime export key for cloudflare is
workerd(not worker).I believe many apps out there might already be relying on
workerso I propose to add it alongside it.Reference :
https://developers.cloudflare.com/workers/wrangler/bundling/#conditional-exports
https://runtime-keys.proposal.wintercg.org/#workerd