Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Fix: Handle NoneType response in is_access_denied_exception #1046

Merged

Conversation

phalbert
Copy link
Contributor

@phalbert phalbert commented Sep 23, 2024

Fixes PORT-10362

Summary

Addresses an issue where the is_access_denied_exception function in the AWS integration could raise an AttributeError if e.response is None. The function now includes a check to ensure e.response is not None before attempting to access its keys.

Changes

  • Added a check in is_access_denied_exception to ensure e.response is not None before accessing its keys.

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

In some scenarios, the AWS integration receives an error that is checked with the `is_access_denied_exception` function. However, if `e.response` is `None`, it leads to an `AttributeError`. This fix adds a check to ensure `e.response` is not `None` before attempting to access its keys, preventing the `AttributeError`.
@phalbert phalbert requested a review from a team as a code owner September 23, 2024 15:31
@phalbert phalbert self-assigned this Sep 23, 2024
@github-actions github-actions bot added size/S and removed size/XS labels Sep 23, 2024
Copy link
Contributor

@lordsarcastic lordsarcastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some succint fixes in the code

integrations/aws/tests/test_utils.py Outdated Show resolved Hide resolved
integrations/aws/tests/test_utils.py Outdated Show resolved Hide resolved
integrations/aws/tests/test_utils.py Outdated Show resolved Hide resolved
integrations/aws/tests/test_utils.py Outdated Show resolved Hide resolved
@Tankilevitch Tankilevitch merged commit a49d0b2 into main Sep 23, 2024
15 checks passed
@Tankilevitch Tankilevitch deleted the PORT-10362-bug-aws-integration-does-not-handle-all-errors branch September 23, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants