Fix crossProjectBaseDirectory
#156
Conversation
| @@ -18,21 +18,24 @@ lazy val root = | |||
| check := { | |||
| doCheckPlatform(crossProjectPlatform.value, "jvm") | |||
| doCheckType(crossProjectCrossType.value, CrossType.Pure) | |||
| doCheckBase(crossProjectBaseDirectory.value, file("root")) | |||
| doCheckBase(crossProjectBaseDirectory.value, | |||
| file("root").getAbsoluteFile) | |||
There was a problem hiding this comment.
Move the .getAbsoluteFile inside def doCheckBase?
| settings( | ||
| CrossPlugin.autoImport.crossProjectBaseDirectory := dir.getAbsoluteFile) | ||
| .mapProjectsByPlatform((platform, project) => | ||
| project.in(crossType.platformDir(dir, platform))) |
There was a problem hiding this comment.
The formatting here is downright misleading. Can you convince scalafmt not to destroy readability here? Perhaps import CrossPlugin.autoImport._ at the top of the file, and use unqualified key names.
Apparently, this is happening at "build loading time" here: |
armanbilge
force-pushed
the
fix/cross-project-base-dir
branch
from
f4d7bd7
to
4972b7c
Compare
|
Thanks, that was very helpful! Is this what you had in mind? |
Sorry, there were some misses in the initial implementation 😕
The vanilla
baseDirectorysetting (always?) returns an absolute file so I would expectcrossProjectBaseDirectoryto do so as well.Changes to the base directory with
CrossProject#inwas not being reflected in thecrossProjectBaseDirectorysetting.The fixes work, but I wonder if there is a more principled way we should do this.
In sbt, the
Project#baseis a relative file butthisProject.value.baseis absolute. So the change is somehow happening in between but I couldn't quite figure out how.