Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme system #2164

Merged
merged 16 commits into from
May 27, 2024
Merged

Theme system #2164

merged 16 commits into from
May 27, 2024

Conversation

htotoo
Copy link
Member

@htotoo htotoo commented May 26, 2024

This will add whole system theme options.
While checking, please look for missing or unreadable texts, and report them with screenshots.

Also in the future apps it will be required (if merged) to use colors + styles from the Theme class.

@htotoo
Copy link
Member Author

htotoo commented May 26, 2024

The important part is theme.hpp, theme.cpp.
Oc the others are important too, for example the default theme should match the original. Like color::grey() ->Theme::... fg_medium.foreground or bg_medium.background

If I swapped it somewhere there could be missing or unreadable text. (Like black on black, ...)

@htotoo htotoo linked an issue May 26, 2024 that may be closed by this pull request
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's merge and ask people to test and report if you missed some widgets, else it's an awesome work.
Good job, thanks :-)

@gullradriel
Copy link
Member

After a bit of testing everything looks good to me, at least enough for merging.

@gullradriel gullradriel merged commit ced8012 into portapack-mayhem:next May 27, 2024
3 checks passed
@htotoo htotoo deleted the theme branch May 27, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Themed GUI
2 participants