Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only inverted or fakebrightness #2240

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Conversation

htotoo
Copy link
Member

@htotoo htotoo commented Sep 7, 2024

No description provided.

@htotoo htotoo requested a review from zxkmm September 7, 2024 15:35
Copy link
Contributor

@zxkmm zxkmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if you also add this logic:

if (!pmem::ui_hide_fake_brightness() && !pmem::config_lcd_inverted_mode()) status_icons.add(&button_fake_brightness);

but it's already good enough, so i approved

@htotoo htotoo merged commit 1f78646 into portapack-mayhem:next Sep 8, 2024
3 checks passed
@htotoo htotoo deleted the dispinv2 branch September 8, 2024 07:35
@htotoo
Copy link
Member Author

htotoo commented Sep 8, 2024

it would be nice if you also add this logic:

if (!pmem::ui_hide_fake_brightness() && !pmem::config_lcd_inverted_mode()) status_icons.add(&button_fake_brightness);

but it's already good enough, so i approved

That would complicate the settings part, adding it back or removing it. It is easier, and hopefully the functionality will come back for inverted too soon.

@zxkmm
Copy link
Contributor

zxkmm commented Sep 8, 2024

How complicate? Sorry I don’t understand, it’s just don’t display the sun icon if invert enabled. It doesn’t touch p.mem and also won’t bring conflict or 3-status logic.

@htotoo
Copy link
Member Author

htotoo commented Sep 8, 2024

Yeah, but what if i turn it off. Then on again. Then off again. Runtime adding or removing icons from there is not easily doable iirc

@zxkmm
Copy link
Contributor

zxkmm commented Sep 8, 2024

From my test, every view change (like if you touch back button or exit an app) would trigger that refresh methods, so logically for the UI, it refreshing like all the time too.

@zxkmm
Copy link
Contributor

zxkmm commented Sep 8, 2024

So you don’t need to manually manage the display/hide. It refresh, and read status, statically add, and that’s all

@zxkmm
Copy link
Contributor

zxkmm commented Sep 8, 2024

I posed a video in discord dev channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants