Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Babel #170

Closed
wants to merge 1 commit into from
Closed

Update Babel #170

wants to merge 1 commit into from

Conversation

jonathantneal
Copy link
Member

It would be really sweet if we could also upgrade Babel before the next release. We can just give it a day or two; and if no one can solve it then I can roll it back and release 6 anyway.

@jonathantneal
Copy link
Member Author

> postcss-selector-parser@6.0.0 pretest ~/GitHub/postcss/postcss-selector-parser
> eslint src


> postcss-selector-parser@6.0.0 test ~/GitHub/postcss/postcss-selector-parser
> nyc ava src/__tests__/*.js

~/GitHub/postcss/postcss-selector-parser/node_modules/@babel/traverse/lib/path/context.js:60
      throw new Error(`Unexpected return value from visitor method ${fn}`);
      ^

Error: Unexpected return value from visitor method function (path) {
          return fn.call(state, path, state);
        }

@alexander-akait
Copy link
Collaborator

Weird, i think we should update ava first (to be honest i prefer jest 😄 )

@jonathantneal
Copy link
Member Author

@evilebottnawi, ava changed how its throw works, and that would require us to update functions used by the tests. I chose not to take that on yet. Other than that, it’s just 2 snapshots that I had to update.

@alexander-akait
Copy link
Collaborator

@jonathantneal what do you think about CI error?

@jonathantneal
Copy link
Member Author

@evilebottnawi, I’ve restored the package-lock.json file.

After updating the babel dependencies in package.json, I deleted package-lock.json so that it could be regenerated. However, when the prepare script failed on npm install, it also failed to regenerate package-lock.json. I didn’t catch this. Thank you!

@jonathantneal jonathantneal deleted the release/6.0.0 branch March 6, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants