Fix PTDF sign instability #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caio Luke <caioluke97@gmail.com>
OpenSuze
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Thank you for your PR !
I have a lot of questions !
- Do you have any test to highlight this behavior ?
- Could you document the reason of the sign flipping in the documentation ?
- Is it an issue with any rescaler that are based on a terminal ?
- Could you refactor this code to avoid comments ?
- Could you provide something like an empty contingency to trigger the fixZeroFunctionReference instead of duplicating code ?
- Why are they not rescaling when there is no contingency ?
- Should this not be a PR in powsybl-open-loadflow ?
|
Thanks for your reply :) I have a test case but the data is confidential... I will try to come up with a minimal case |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Current PTDF values are not sign stable for contingency cases in flow decomposition.
When calculating them, we skip a method that fixes the function value because we apply the contigency modifications directly to the network.
What is the new behavior (if this is a feature change)?
PTDF signs for contingency cases are sign stable.
Does this PR introduce a breaking change or deprecate an API?