Fix TypeError When Using @Paginate() with @MessagePattern() (@nestjs/microservices)

[AAAAAAAAlan]

Problem

Currently, when the @Paginate() decorator is used alongside the @MessagePattern() decorator within a NestJS microservice, an error is thrown. This occurs because ExecutionContextHost.switchToHttp().getRequest() does not contain a query key in 'rpc' mode, leading to undefined being returned and causing the following TypeError:

TypeError: Cannot read properties of undefined (reading 'searchBy')

This error specifically arises due to the incompatibility of the @Paginate() decorator expecting HTTP request objects in an environment where such objects are not available.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (bbf3b4a) to head (90d4f6d).
Report is 2 commits behind head on master.

❗ Current head 90d4f6d differs from pull request most recent head abd25d1

Please upload reports for the commit abd25d1 to get more accurate results.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          16       16           
  Lines         652      653    +1     
  Branches      190      192    +2     
=======================================
+ Hits          638      639    +1     
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Helveg]

I'm unfamiliar with RPC, could you explain why request instead of request.query is an appropriate fix?

[AAAAAAAAlan]

I'm unfamiliar with RPC, could you explain why request instead of request.query is an appropriate fix?

While using @MessagePattern - request variable contains query parameters in itself and nothing more. Im also unfamiliar with RPC, I did some "console.logging" and found that out.

I'm not really interested in contributing or finding other, better solutions. This fix works perfectly in my project, and I just wanted to highlight the issue for maintainers and fellow gamers

[Helveg]

Finished OP's PR.

(Sort of) added (untested) WS & RCP support, assuming that their query will be in getData().

[Helveg]

@ppetzold could you have a look?

[Helveg]

@ppetzold ping :)

[ppetzold]

nicely done 🚀

[ppetzold]

🎉 This PR is included in version 9.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀