Upgrade MathJax to 3.2.2 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leimao
commented
Dec 30, 2023
leimao
commented
- Updated MathJax CDNs.
- Updated MathJax Configs for MathJax 3.
ppoffice
reviewed
Jan 5, 2024
| matchFontHeight: false | ||
| }, | ||
| SVG: { | ||
| matchFontHeight: false |
leimao
commented
Jan 6, 2024
src/view/plugin/mathjax.jsx
Outdated
|
|
||
| return ( | ||
| <> | ||
| <script type="text/x-mathjax-config" dangerouslySetInnerHTML={{ __html: js }}></script> | ||
| <script dangerouslySetInnerHTML={{ __html: js }}></script> |
There was a problem hiding this comment.
看官方文档的意思，我是不是在这里还得加一个 type="text/javascript" id="MathJax-script" async?
leimao
commented
Jan 6, 2024
|
|
||
| return ( | ||
| <> | ||
| <script type="text/x-mathjax-config" dangerouslySetInnerHTML={{ __html: js }}></script> | ||
| <script src={jsUrl} defer={true}></script> |
There was a problem hiding this comment.
@ppoffice 我把这个defer attribute 给删除了，您看看我这么做合理吗？
There was a problem hiding this comment.
因为你用async替换了defer而且这个script在HTML的底部所以差别不大。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.