Bump SixLabors.ImageSharp to v2.1.0
#5087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to use the new and default `ArrayPool`-based memory allocator (see SixLabors/ImageSharp#1730).
frenzibyte
commented
Apr 1, 2022
osu.Framework/Platform/GameHost.cs
Outdated
| // recommended middle-ground https://github.com/SixLabors/docs/blob/master/articles/ImageSharp/MemoryManagement.md#working-in-memory-constrained-environments | ||
| SixLabors.ImageSharp.Configuration.Default.MemoryAllocator = ArrayPoolMemoryAllocator.CreateWithModeratePooling(); | ||
| // recommended middle-ground https://github.com/SixLabors/docs/blob/main/articles/imagesharp/memorymanagement.md#configuring-the-pool-size | ||
| SixLabors.ImageSharp.Configuration.Default.MemoryAllocator = MemoryAllocator.Create(new MemoryAllocatorOptions { MaximumPoolSizeMegabytes = 1 }); |
There was a problem hiding this comment.
Maximum pool size number comes from the previously used method CreateWithModeratePooling() (1024 * 1024).
Note that the default memory allocator uses one eighth of the platform's available memory according to GC.GetMemoryInfo(), which might consider this logic no longer necessary, unsure.
There was a problem hiding this comment.
After reading their new implementation, I believe we should remove this custom spec completely and see how things perform. The reason we had this was that the pool never cleaned up, but the documentation says it now does.
1 task
peppy
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for supporting macOS image clipboards, requiring TIFF encoder/decoder which is supported in ImageSharp v2.1.0.
Breaking changes come from SixLabors/ImageSharp#1730.
The important one is that
ArrayPoolMemoryAllocatorhas been completely replaced with the new and defaultUniformUnmanagedMemoryPoolMemoryAllocator, which is still partiallyArrayPool-based for smaller allocations, but uses a different pool implementation for larger allocations.I can't check on the performance side of this, so would appreciate that being done prior to merge.