Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Add oauth redirect listener #634

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add oauth redirect listener #634

wants to merge 6 commits into from

Commits on Aug 15, 2022

  1. Add oauth redirect listener 

    Add an HTTP listener for use as the redirect_uri. This will allow gdrive
to work after google phases out the "oob" redirect.
Also implement oauth PKCE (code challenge)

Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
    @cg2v
    cg2v committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    9e6bf6e View commit details
    Browse the repository at this point in the history

  2. Remove debug prints from oauth code 

    Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
    @cg2v
    cg2v committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    ed8a4c1 View commit details
    Browse the repository at this point in the history

  3. Finish renaming redirect to callback 

    The redirect_uri is where the google server redirects after completing
authentication.
From our perspective, it's a callback, not a redirect.
Our authorize uri redirects to google, so it would be confusing
to refer to the other url as a redirect

Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
    @cg2v
    cg2v committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    df2696c View commit details
    Browse the repository at this point in the history

  4. Remove PKCE support 

    The vendored oauth2 module doesn't support extra token exchange args.
As that is how PKCE is implemented, remove it

Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
    @cg2v
    cg2v committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    e2f72fd View commit details
    Browse the repository at this point in the history

  5. Go 1.13 does not have Map.Has. Use Get instead 

    Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
    @cg2v
    cg2v committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    63fe9a1 View commit details
    Browse the repository at this point in the history

  6. Use constants for clientid 

    fix issue introduced in backport from msfjarvis branch;
refer to ClientId and ClientSecret constants instead of (absent)
parameters

Signed-off-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
    @cg2v
    cg2v committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    b6d4d53 View commit details
    Browse the repository at this point in the history