Improve perf of diffed hook #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JajarGaming
reviewed
May 14, 2023
| performance.clearMarks(start); | ||
| performance.clearMarks(end); | ||
| } catch (e) { | ||
| // Do nothing |
marvinhagemeister
approved these changes
Apr 25, 2024
|
@andrewiggins I'm curious if you tested this with Firefox? I'm getting crazy slow performance in Firefox now which seems to be coming from |
|
Oh, looks like Chrome is still on 4.7.1 so it might not be a Firefox-specific issue after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed in browser traces at work that the devtools extension is showing up a lot in traces and is causing jank in our page. While it doesn't affect users, I don't want my team to get the wrong impressions about Preact's perf when they are browsing localhost with devtools installed. So this change is attempting to improve the perf of devtools hooks so that it doesn't impact the page.
Sample screenshot of what I see in browser traces:
