Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capturing and non-capturing listeners on the same element #2740

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

devongovett
Copy link
Contributor

Fixes #2739.

Open to suggestions on making it smaller/better. Not too happy with having two event proxy functions, but didn't think of a better way so far.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.805% when pulling 624f43d on devongovett:fix-capture into bf3f96f on preactjs:master.

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you so much for this PR! Also a great added test 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onKeyDownCapture and onKeyDown overwrite each other
3 participants