Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the adapter according to preCICE V3 #25

Merged
merged 19 commits into from
Sep 19, 2023
Merged

Update the adapter according to preCICE V3 #25

merged 19 commits into from
Sep 19, 2023

Conversation

Fujikawas
Copy link
Contributor

@Fujikawas Fujikawas commented Aug 10, 2023 •
edited
Loading

Description

Update to align the adapter with preCICE V3.

Checklist

  • I made sure that the source files are formatted properly.
  • I added my changes to the changelog (CHANGELOG.md)
  • I updated the documentation.

@Fujikawas Fujikawas marked this pull request as draft August 15, 2023 07:36
@Fujikawas
Copy link
Contributor Author

Still in progress since the test run failed.

@Fujikawas Fujikawas marked this pull request as ready for review August 16, 2023 10:57
@Fujikawas
Copy link
Contributor Author

Still in progress since the test run failed.

Finished-> tests passed with the latest PreCICE develop branch.

IshaanDesai
IshaanDesai reviewed Aug 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
IshaanDesai
IshaanDesai requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially reviewed, will continue with the review tomorrow.

IshaanDesai
IshaanDesai requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a second review cycle. Lets discuss the name changes before implementing them for the examples.

@IshaanDesai
Copy link
Member

Needs to be synced with develop to fix the CI

@IshaanDesai IshaanDesai mentioned this pull request Sep 14, 2023
Merged
1 task
@IshaanDesai IshaanDesai added the breaking change A change will break backwards compatibilty label Sep 15, 2023
IshaanDesai
IshaanDesai approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at everything again, but tests passing is already a good sign.

@Fujikawas Fujikawas merged commit 71b7bd8 into precice:develop Sep 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees

@Fujikawas Fujikawas

Labels
breaking change A change will break backwards compatibilty
Projects
preCICE version 3 overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fujikawas @IshaanDesai