Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming and remove unused self._coupling_subdomain #129

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Update naming and remove unused self._coupling_subdomain #129

merged 1 commit into from
Apr 20, 2021

Conversation

BenjaminRodenberg
Copy link
Member

Related to #7.

@BenjaminRodenberg BenjaminRodenberg added the enhancement New feature or request label Apr 20, 2021
IshaanDesai
IshaanDesai approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I missed this, good clean-up 👍

@BenjaminRodenberg BenjaminRodenberg marked this pull request as ready for review April 20, 2021 15:16
@BenjaminRodenberg BenjaminRodenberg merged commit 6ad5622 into develop Apr 20, 2021
@BenjaminRodenberg BenjaminRodenberg deleted the cleanup-coupling-subdomain branch April 20, 2021 15:17
@BenjaminRodenberg BenjaminRodenberg added this to the v1.2.0 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminRodenberg @IshaanDesai