-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility update for v3.0.0 #153
Merged
Merged
Changes from 7 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
8d48839
Remove API functions that are removed in v3.0.0. Fix data initializat…
BenjaminRodenberg 41d5f0a
Forward dt to python bindings.
BenjaminRodenberg db80fd6
Fix formatting.
BenjaminRodenberg d9c93fe
Merge branch 'develop' into compatibility-v3.0.0
IshaanDesai 24814d5
Updates according to precice:develop
IshaanDesai 60ba637
Formatting
IshaanDesai dee8c4f
Set mesh connectivity information only if it is required. Closes #138
IshaanDesai e9494b4
Add mock call to requires_mesh_connectivity_for in tests
IshaanDesai 069f7fb
Add mock call to requires_initial_data in tests
IshaanDesai 8945805
Update links of contributors
IshaanDesai 10e2d5f
Update CHANGELOG.md
BenjaminRodenberg cfec85d
Call checkpointing functions from the interface
IshaanDesai 641aa04
Making adapter and tests compatible with the latest development stage
IshaanDesai b0a612e
Formatting
IshaanDesai ff99c95
Repair set_mesh_edges unit test
IshaanDesai 52eecbe
Merge branch 'develop' into compatibility-v3.0.0
BenjaminRodenberg d6e5989
Merge branch 'develop' into compatibility-v3.0.0
BenjaminRodenberg 87af390
Merge branch 'develop' into compatibility-v3.0.0
BenjaminRodenberg 748c934
Get tests working again.
BenjaminRodenberg 127fdd3
Change required version of pyprecice to >=3.0.0.0
IshaanDesai f661455
Formatting
IshaanDesai 9935467
Fix version requirement to also support dev version.
BenjaminRodenberg 2ae1de5
Use develop docker image.
BenjaminRodenberg ef63119
Fix assertion.
BenjaminRodenberg 90d533a
Merge branch 'develop' into compatibility-v3.0.0
BenjaminRodenberg 4aff969
Use run.sh.
BenjaminRodenberg 5e8c632
Fix metadata for mocked bindings
BenjaminRodenberg 3beffd7
Add test.
BenjaminRodenberg 5ffe18b
Comment out nearest projection volume coupling.
BenjaminRodenberg 53ecec0
Merge branch 'compatibility-v3.0.0' of github.com:precice/fenics-adap…
BenjaminRodenberg 86f2d4a
Update changelog.
BenjaminRodenberg 0a96fd5
Fix format.
BenjaminRodenberg 92b3eac
Explicitly mention that this is a breaking release of the FEniCS adap…
BenjaminRodenberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this problem by running
channel-transport-reaction
. But even fixing this obviously wrong assertion does not help. There seems to be some issue with the functionget_coupling_triangles
. We obviously need a test for this function and need to fix it. @IshaanDesai can you take a look?