Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for lazy creation of micro simulations #117

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mathiskelm
Copy link
Collaborator

@mathiskelm mathiskelm commented Jul 26, 2024

Micro simulations that are never solved don't require the microsim object to be created in the first place. If the creation/initialization is costly, avoiding it can save significant time/memory and allow simulation on smaller systems/of larger problems. In this PR the creation of micro simulations is delayed to activation.

TODO:

  • Avoid code duplication for creation of micro sims,
  • Improve compatibility with other Micro-Manager capabilities such as initialization of micro-sims.
  • Improve error handling of incompatible settings (without initial macro data the simulation will start with only 1 micro sim)

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@mathiskelm mathiskelm changed the title add option for lazy creation of microsims Add option for lazy creation of micro simulations Jul 26, 2024
@IshaanDesai IshaanDesai added the enhancement Enchance existing functionality label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enchance existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants