Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build and store a Docker image #184

Closed
wants to merge 46 commits into from
Closed

CI: Build and store a Docker image #184

wants to merge 46 commits into from

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Jun 21, 2021

This PR builds a Docker image with preCICE, OpenFOAM, and the current state of the OpenFOAM adapter from the add-ci-docker branch, and pushes it to GHCR. (under construction, currently experimenting)

TODO list:

  • I updated the documentation in docs/
  • I added a changelog entry in changelog-entries/ (create directory if missing)

@BenjaminRodenberg
Copy link
Member

I would like to review this PR as soon as it is done (just as a note). Especially, since I have my own similar side project here: https://github.com/precice/fenics-adapter/blob/develop/.github/workflows/build-docker.yml. We should try to synchronize these two before we roll the methodology out to all adapters etc.

@MakisH
Copy link
Member Author

MakisH commented Aug 2, 2023

We now have a first minimal version of the system tests in the develop branch of the tutorials, which builds a Docker image of the OpenFOAM adapter on demand when triggered, given arguments regarding the OpenFOAM version etc.

To avoid publishing intermediate images, we want to rely on the GitHub Actions cache. Read more in precice/precice#1700.

We could still publish Docker images of the released versions of the adapter, to reduce the runtime of specific workflows.

@MakisH
Copy link
Member Author

MakisH commented Aug 8, 2023

Closing in favor of the multi-stage Docker build approach discussed in precice/precice#1700

After a first prototype for that works, we should also remove the published test image from the GitHub Container Registry.

@MakisH MakisH closed this Aug 8, 2023
@MakisH MakisH reopened this Aug 9, 2023
@MakisH
Copy link
Member Author

MakisH commented Sep 18, 2023

Closing as the same goal is now achieved by precice/tutorials#364.
Deleting the old Docker image as well.

@MakisH MakisH closed this Sep 18, 2023
@MakisH MakisH deleted the add-ci-docker branch November 22, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants