Make news global #234
Merged
Make news global #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Thank you, this looks really nice, as we now have a specific file to change and this will be included by Jekyll on the landing or every page.
I added a class banner-container and adjusted the margins to fix the spacing on non-landing pages. On Firefox, this seems to work on all three cases (true/false/include.onlanding).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the news banner html to its own
_include/news-banner.html.It is included in every page, use the boolean
include.onlandinginside to determine where to show the banner.I needed to add a
.banner { padding: 15px 0; }to thecustomstyles.cssto make this look decent on non-landing pages.