Move computation of adaptive dt before read #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the computation of the adaptive
solverDt
happens after the read. I would argue that it should happen before the read. I guess the original idea here was that the computation of thesolverDt
depends on the quantity that was read. However, I think this does not make sense for the following two reasons:dt
before reading, not after. See also v3: Make dt mandatory in documentation #257solverDt
depends on the quantity read from preCICE, then we need to read that quantity also at the right location in time. This leads somehow to a deadlock, that we could, for example, solve by iterating: