Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community section in landing page #264

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Apr 25, 2023

Adds a "Join the community!" section in the landing page.

  • After the academic, before the support program, but short to not steal too much attention. This also fits the natural path (internal -> open -> open + support).
  • No button "Contribute to preCICE", to avoid too much visual repetition compared to the "Support preCICE", which I used as starting point. We have too many buttons anyway. There is a link to the same page in the text.
  • I already considered putting the photo on the left, to alternate from the section below. But it then looks very strange as not aligned with the section heading, and the image comes before the text in small screens. On the right, it also naturally connects with the last text line.
  • Changed the picture to have a ratio of 1:2, thinking it would help me with the implementation. In any case, it increases the people/background ratio.

I have used this StackOverflow answer for the cropping part. Later, I saw that there were more methods, but this one worked already.

Reviews:

  • @uekerman please check the content and position
  • @fsimonis please check the implementation

Screenshots in different views:

Screen Shot 2023-04-25 at 18 06 14
Screen Shot 2023-04-25 at 18 06 00
Screen Shot 2023-04-25 at 18 05 29
Screen Shot 2023-04-25 at 18 05 10

@MakisH MakisH added content Content-only issues technical Technical issues on the website labels Apr 25, 2023
@MakisH MakisH self-assigned this Apr 25, 2023
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content and position is good.
Thanks for adding this 👍

Only thing: On one of your screenshots some head is cut.

Copy link
Member

@fsimonis fsimonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified the html/css and directly pushed the update.
Looks like you were fighting the panel class.

The outcome looks good on any device. Let's not add additional css.

@MakisH
Copy link
Member Author

MakisH commented Apr 26, 2023

I was indeed fighting the panel class, but I wanted to use it (or another container) to have rounded corners and the cropping feature.

Anyway, it does not look bad now either, it's just a bit... plain. 😬

@MakisH MakisH merged commit 53298ed into precice:master Apr 26, 2023
@MakisH MakisH deleted the community-landing branch April 26, 2023 12:23
@fsimonis
Copy link
Member

@MakisH Like this? 😃 dd86efc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content-only issues technical Technical issues on the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants