Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update couple your code #315

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Update couple your code #315

merged 3 commits into from
Dec 22, 2023

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Dec 11, 2023 •
edited
Loading

This PR updates the couple your code section.

Exceptions are:

@fsimonis
Copy link
Member Author

I must double-check, but I think [...] breaks code highlighting in C++ files.

Maybe we should go for:

// ...

// or

/* ... */

IshaanDesai
IshaanDesai approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 just some minor comments.

@fsimonis @IshaanDesai
Apply suggestions from code review
16bca07 
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
@fsimonis fsimonis merged commit ddc09d0 into precice-v3 Dec 22, 2023
1 check passed
@fsimonis fsimonis deleted the update-couple-your-code branch December 22, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsimonis @IshaanDesai