Update couple-your-code-porting-v2-3.md #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readData doesn't need numberOfVertices anymore! I removed this from the example.
davidscn
reviewed
Feb 14, 2024
| @@ -153,7 +153,7 @@ The previously optional argument `relativeReadTime` is now mandatory for read da | |||
| ```diff | |||
| - couplingInterface.readBlockVectorData(meshName, dataReadName, numberOfVertices, vertexIDs.data(), readData.data()); | |||
| + preciceDt = couplingInterface.getMaxTimeStepSize(); | |||
| + couplingInterface.readBlockVectorData(meshName, dataReadName, numberOfVertices, vertexIDs.data(), preciceDt, readData.data()) | |||
| + couplingInterface.readBlockVectorData(meshName, dataReadName, vertexIDs.data(), preciceDt, readData.data()) | |||
There was a problem hiding this comment.
Suggested change
| + couplingInterface.readBlockVectorData(meshName, dataReadName, vertexIDs.data(), preciceDt, readData.data()) | |
| + couplingInterface.readData(meshName, dataReadName, vertexIDs, preciceDt, readData) |
The complete signature of this function is v2.
There was a problem hiding this comment.
Maybe even call the object participant, i.e. participant.readData, just as in the example above.
| @@ -162,7 +162,7 @@ If you use subcycling, please do the following: | |||
| - couplingInterface.readBlockVectorData(meshName, dataReadName, numberOfVertices, vertexIDs.data(), readData.data()); | |||
| + preciceDt = couplingInterface.getMaxTimeStepSize(); | |||
| double dt = min(preciceDt, solverDt); | |||
| + couplingInterface.readBlockVectorData(meshName, dataReadName, numberOfVertices, vertexIDs.data(), dt, readData.data()) | |||
| + couplingInterface.readBlockVectorData(meshName, dataReadName, vertexIDs.data(), dt, readData.data()) | |||
There was a problem hiding this comment.
Suggested change
| + couplingInterface.readBlockVectorData(meshName, dataReadName, vertexIDs.data(), dt, readData.data()) | |
| + couplingInterface.readData(meshName, dataReadName, vertexIDs, dt, readData) |
|
Thanks for the review! I have applied your changes and I applied them to the rest of the porting guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readData doesn't need numberOfVertices anymore! I removed this from the example.