Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit workflow #337

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Add pre-commit workflow #337

merged 4 commits into from
Mar 7, 2024

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Feb 19, 2024 •
edited
Loading

This PR replaced the check markdown workflow with a workflow which runs pre-commit.

This ensures that the linting here is consistent with what the user should run into when committing.

@fsimonis fsimonis requested a review from MakisH February 19, 2024 13:45
@MakisH
Copy link
Member

MakisH commented Mar 1, 2024

We should also mention in the README.md how to get and use the pre-commit hook. Linking to the related note for preCICE is fine.

@fsimonis fsimonis merged commit a0efc3e into master Mar 7, 2024
2 checks passed
@fsimonis fsimonis deleted the add-pre-commit-workflow branch March 7, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakisH MakisH Awaiting requested review from MakisH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsimonis @MakisH