Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pages for adapters of DuMuX and DUNE #364

Merged
merged 13 commits into from
Apr 5, 2024
Merged

Add pages for adapters of DuMuX and DUNE #364

merged 13 commits into from
Apr 5, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Mar 27, 2024

The content for the DuMuX and DUNE adapters is directly copied from their respective repository READMEs. Further cleaning and editing can be done in the future.

@IshaanDesai IshaanDesai self-assigned this Mar 27, 2024
@IshaanDesai IshaanDesai requested a review from MakisH March 29, 2024 14:31
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

I ended up almost rewriting this PR, by moving the new pages directly to their repositories. I should have probably just closed this and opened a new one, but why not... 😅

Related PRs in the adapters:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted DUNE to appear before DuMuX, but DuMuX has multiple pages (it is a folder), while DUNE does not (it is not a folder). To be able to rearrange the sidebar, I made everything folders, as more entries would likely come. In a follow-up, I would probably sort these alphabetically already.

@MakisH MakisH merged commit 60ca398 into master Apr 5, 2024
2 checks passed
@MakisH MakisH deleted the add-dune-dumux branch April 5, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants