Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite coupling-data section #366

Merged
merged 11 commits into from
Apr 16, 2024
Merged

Rewrite coupling-data section #366

merged 11 commits into from
Apr 16, 2024

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Apr 2, 2024

This PR attempts to clarify the coupling-data section of the docs

@fsimonis fsimonis requested a review from uekerman April 2, 2024 13:32
@fsimonis fsimonis self-assigned this Apr 2, 2024
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now very clearer! A few suggestions/questions from the user perspective.

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are getting clearer already, but some details need tweaking.

pages/docs/configuration/configuration-acceleration.md Outdated Show resolved Hide resolved
pages/docs/configuration/configuration-acceleration.md Outdated Show resolved Hide resolved
@fsimonis fsimonis requested review from uekerman and MakisH April 5, 2024 14:44
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have some issues here with the examples. When do we use which example? It might be easier to use multiple ones and make things explicit.

pages/docs/configuration/configuration-acceleration.md Outdated Show resolved Hide resolved
pages/docs/configuration/configuration-acceleration.md Outdated Show resolved Hide resolved
pages/docs/configuration/configuration-acceleration.md Outdated Show resolved Hide resolved
pages/docs/configuration/configuration-acceleration.md Outdated Show resolved Hide resolved
fsimonis and others added 5 commits April 12, 2024 16:48
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>
Co-authored-by: Frédéric Simonis <simonisfrederic@gmail.com>
@fsimonis fsimonis merged commit 6701f36 into master Apr 16, 2024
2 checks passed
@fsimonis fsimonis deleted the rework-coupling-data branch April 16, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants