Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the last updated date underneath the edit button #397

Merged
merged 2 commits into from
May 3, 2024
Merged

Add the last updated date underneath the edit button #397

merged 2 commits into from
May 3, 2024

Conversation

fsimonis
Copy link
Member

I tried variations of how to format this for it to become compact:

Updated
Editted
Last edit
Last update

Last edit and update lead to a line break

Solves #282

@uekerman
Copy link
Member

Could you paste a screenshot please?

@fsimonis
Copy link
Member Author

fsimonis commented May 2, 2024

Size Preview
Large image
Medium image
Small image

@fsimonis fsimonis self-assigned this May 2, 2024
MakisH
MakisH approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renderings in the screenshots look very nice! I like the formulation, as well as that it nicely fits the width of the button.

_layouts/page.html Show resolved Hide resolved
@fsimonis fsimonis linked an issue May 3, 2024 that may be closed by this pull request
Add last edit info to pages #282
Closed
@fsimonis fsimonis merged commit 8215810 into master May 3, 2024
2 checks passed
@fsimonis fsimonis deleted the add-last-update branch May 3, 2024 08:45
@uekerman
Copy link
Member

uekerman commented May 3, 2024

Currently, all(?) pages show "Updated 03 May 24"?

@fsimonis
Copy link
Member Author

fsimonis commented May 3, 2024

On it

@fsimonis
Copy link
Member Author

fsimonis commented May 3, 2024

Fixed. We need a deep clone for the website now.

@MakisH
Copy link
Member

MakisH commented May 3, 2024

We still need the same for the imported submodules, though. The tutorials pages, for example, also all show May 3 as last edit.

@fsimonis
Copy link
Member Author

fsimonis commented May 3, 2024

actions/checkout#1124

Looks like we have to manually git clone

@fsimonis
Copy link
Member Author

fsimonis commented May 3, 2024

Opened an issue #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakisH MakisH MakisH approved these changes

Assignees

@fsimonis fsimonis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add last edit info to pages
3 participants
@fsimonis @uekerman @MakisH