Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of schema #21

Merged
merged 3 commits into from
Sep 20, 2024
Merged

First draft of schema #21

merged 3 commits into from
Sep 20, 2024

Conversation

uekerman
Copy link
Member

@uekerman uekerman commented Sep 16, 2024

@MakisH
Copy link
Member

MakisH commented Sep 16, 2024

Very nice linking to the MetaConfigurator as well, but shouldn't we document at least this part somewhere?

Should we maybe have these files in a separate directory adapter-config-schema with a README.md file explaining what this is about and linking to the MetaConfigurator?

Just think of the people that will end up on this file through a search engine.

@uekerman
Copy link
Member Author

uekerman commented Sep 19, 2024

I now created a folder adapter-config-schema at the root of the repo. Is this what you had in mind?
Together with a README.

Ready to merge from my side.

@MakisH
Copy link
Member

MakisH commented Sep 19, 2024

I now created a folder adapter-config-schema at the root of the repo. Is this what you had in mind? Together with a README.

Yes, exactly

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough to be merged already. We will iterate on it soon.

@uekerman uekerman merged commit c227dba into main Sep 20, 2024
@uekerman uekerman deleted the add-schema-draftz branch September 20, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants