-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all FEniCS participants to be compatible with precice:develop (v3) #333
Conversation
…and fenics-adapter updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the cases that work exclusively with FEniCS and fixed a few mistakes here. This seems to work. Did not have the time to also check the cases like elastic-tube-3d
, flow-over-heated-plate
and perpendicular-flap
. Looking at the changes in the diff it looks reasonable, but I think we should definitely run them as well before merging.
* Synchronize with 748c934 from precice/fenics-adapter#153
I updated the basic version of the partitioned heat conduction w.r.t precice/fenics-adapter#153. The other tutorials are still missing, but generally the case seems to work again. |
@IshaanDesai Anything holding us back from merging this PR as soon as its "sibling" precice/fenics-adapter#153 is ready? |
No, nothing holding us back. Running the tutorials manually with the corresponding adapter PR branch should be a sufficient check to merge this. |
I'll do a final round of testing and then I will merge. If other adapters still need an update and there is no possibility for testing, I will rely on just checking the diff for sanity. The basis for the tests are the following components:
|
This PR updates all FEniCS participants to be compatible with precice:develop. The changes should be tested with precice/fenics-adapter#153. Manual testing is necessary, and once cases are known to work, this PR needs to be merged so that the PR mentioned earlier can be tested via CI.