Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FEniCS adapter #357

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Add FEniCS adapter #357

merged 2 commits into from
Aug 4, 2023

Conversation

valentin-seitz
Copy link
Member

@valentin-seitz valentin-seitz commented Aug 4, 2023

In this PR i added preliminary support for the fenics adapter by using only the docker images published on docker hub.
To execute it you can run the newly added fenics-test suite like:
python systemtests.py --suites=fenics-test

I also renamed the build_arguments to be only called build_arguments and removed variations like params or build_args etc.

This PR solves #352

- straightend out the nameing of build_arguments to be more uniform around the code
@valentin-seitz valentin-seitz self-assigned this Aug 4, 2023
@MakisH MakisH changed the title Added fenics adapter Add FEniCS adapter Aug 4, 2023
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test suite works, changes look reasonable.
Only some unclear changes in the README.

tools/tests/README.md Show resolved Hide resolved
tools/tests/README.md Outdated Show resolved Hide resolved
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
@valentin-seitz valentin-seitz merged commit b77f0b4 into develop Aug 4, 2023
5 checks passed
@MakisH MakisH deleted the add-fenics-adapter branch August 7, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants