Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioned heat conduction with Schwarz-type domain decomposition #381

Merged
merged 24 commits into from
Feb 5, 2024

Conversation

BenjaminRodenberg
Copy link
Member

Adds a tutorial illustrating how Schwarz-type domain decomposition could be implemented with preCICE.

General question similar to #30: How can we publish these kind of academic and advanced tutorials in a proper way?

@BenjaminRodenberg BenjaminRodenberg self-assigned this Oct 6, 2023
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a picture showing the overlapping domain? I think this could be very helpful to quickly grasp the difference of this tutorial to others.

How can we publish these kind of academic and advanced tutorials in a proper way?

This discussion will be part of the preECO project. Let's not preempt a decision here. For the moment, what you did looks good.

I did not run the case.

partitioned-heat-conduction-schwarz/README.md Outdated Show resolved Hide resolved
partitioned-heat-conduction-schwarz/README.md Outdated Show resolved Hide resolved
partitioned-heat-conduction-schwarz/README.md Outdated Show resolved Hide resolved
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name and README look good enough for me. I did not run the case.

@uekerman uekerman requested a review from MakisH February 2, 2024 15:10
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tried to run this tutorial, but it anyway needs porting to preCICE v3.

I would also prefer that it already applies the tutorial structure that we have essentially discussed and converged on, which is documented in https://precice.org/community-contribute-to-precice.html

Other than that, it looks clean and clear. I particularly like that you added the TikZ sources for the figure.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new structure is nice! 👍
I ran the code, no VTK files are produced (as expected, I supposed).
I then executed the solver-fenics/errorcomputation.py and got no output, which confused me but means that the assertion worked.

* `python3 heat.py left` flag will run the left participant.
* `python3 heat.py right` flag will run the right participant.

Like for the case `partitioned-heat-conduction` (using Dirichlet-Neumann coupling), we can also expect for the overlapping domain decomposition applied here to recover the analytical solution. `errorcomputation.py` checks this explicitly, by comparing the numerical to the analytical solution and raising an error, if the approximation error is not within a given tolerance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Like for the case `partitioned-heat-conduction` (using Dirichlet-Neumann coupling), we can also expect for the overlapping domain decomposition applied here to recover the analytical solution. `errorcomputation.py` checks this explicitly, by comparing the numerical to the analytical solution and raising an error, if the approximation error is not within a given tolerance.
Like for the case `partitioned-heat-conduction` (using Dirichlet-Neumann coupling), we can also expect for the overlapping domain decomposition applied here to recover the analytical solution. The script `solver-fenics/errorcomputation.py` checks this explicitly, by comparing the numerical to the analytical solution and raising an error, if the approximation error is not within a given tolerance.

Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
@BenjaminRodenberg
Copy link
Member Author

I ran the code, no VTK files are produced (as expected, I supposed).

I don't completely understand this. I get VTK output...?

Screenshot from 2024-02-05 23-27-53

@BenjaminRodenberg BenjaminRodenberg merged commit 16ce778 into precice:develop Feb 5, 2024
3 checks passed
@BenjaminRodenberg BenjaminRodenberg deleted the schwarz-dd branch February 5, 2024 22:29
@MakisH
Copy link
Member

MakisH commented Feb 6, 2024

I ran the code, no VTK files are produced (as expected, I supposed).

I don't completely understand this. I get VTK output...?

I guess I overlooked the output/ folder, used to having the Nutils output in the same directory. But this is not our Nutils tutorials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants