Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non terminating timeouts #421

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix non terminating timeouts #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tools/tests/systemtests/Systemtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,13 +354,12 @@ def _run_field_compare(self):
stdout, stderr = process.communicate(timeout=GLOBAL_TIMEOUT)
except KeyboardInterrupt as k:
process.kill()
# process.send_signal(9)
raise KeyboardInterrupt from k
except Exception as e:
logging.critical(
f"Systemtest {self} had serious issues executin the docker compose command about to kill the docker compose command. Please check the logs! {e}")
f"Systemtest {self} had serious issues executing the docker compose command about to kill the docker compose command. Please check the logs! {e}")
process.kill()
stdout, stderr = process.communicate()
process.communicate(timeout=10)
stdout_data.extend(stdout.decode().splitlines())
stderr_data.extend(stderr.decode().splitlines())
process.poll()
Expand Down Expand Up @@ -397,16 +396,16 @@ def _build_docker(self):
cwd=self.system_test_dir)

try:
stdout, stderr = process.communicate()
stdout, stderr = process.communicate(timeout=GLOBAL_TIMEOUT)
except KeyboardInterrupt as k:
process.kill()
# process.send_signal(9)
raise KeyboardInterrupt from k
except Exception as e:
logging.critical(
f"systemtest {self} had serious issues building the docker images via the `docker compose build` command. About to kill the docker compose command. Please check the logs! {e}")
process.communicate(timeout=10)
process.kill()
stdout, stderr = process.communicate()

stdout_data.extend(stdout.decode().splitlines())
stderr_data.extend(stderr.decode().splitlines())
Expand Down Expand Up @@ -448,9 +447,10 @@ def _run_tutorial(self):
raise KeyboardInterrupt from k
except Exception as e:
logging.critical(
f"Systemtest {self} had serious issues executin the docker compose command about to kill the docker compose command. Please check the logs! {e}")
f"Systemtest {self} had serious issues executing the docker compose command about to kill the docker compose command. Please check the logs! {e}")
process.kill()
stdout, stderr = process.communicate(timeout=10)
process.kill()
stdout, stderr = process.communicate()

stdout_data.extend(stdout.decode().splitlines())
stderr_data.extend(stderr.decode().splitlines())
Expand Down
Loading