Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several compatibility updates to the two-scale-heat-conduction tutorial #460

Merged
merged 7 commits into from
Mar 20, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Feb 7, 2024

This PR includes a bunch of updates for the two-scale-heat-conduction tutorial, to make it compatible with the latest state of the Micro Manager. The Micro Manager will be released soon, which will finalize the changes here.

@IshaanDesai IshaanDesai self-assigned this Feb 7, 2024
@IshaanDesai IshaanDesai added this to the v202403.0 milestone Feb 29, 2024
@IshaanDesai IshaanDesai marked this pull request as ready for review March 20, 2024 13:49
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to adapt the pybind wrapper to the constructor taking an argument simulationID, i.e. in the wrapper's constructor and setstate functions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not straightforward and has now been documented in an issue in the Micro Manager repository: precice/micro-manager#87

@IshaanDesai IshaanDesai merged commit eb3daf5 into precice:develop Mar 20, 2024
1 check passed
@IshaanDesai IshaanDesai deleted the compatibility_multiscale branch March 20, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants