Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the dunefem solver for flow-over-heated-plate simulation for preCICE v3 #470

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Port the dunefem solver for flow-over-heated-plate simulation for preCICE v3 #470

merged 7 commits into from
Mar 21, 2024

Conversation

Fujikawas
Copy link
Contributor

The DUNE components of version 2.9 are used for test.

@IshaanDesai IshaanDesai added this to the v202403.0 milestone Feb 24, 2024
IshaanDesai
IshaanDesai approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Looks good 👍 Only one minor comment from my side. I did not run this tutorial.

@fsimonis fsimonis requested a review from uekerman March 20, 2024 10:36
uekerman
uekerman approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can run the case and the results look good.

I added a venv here. FYI @MakisH then we don't have to install dune-fem in the VM.

@MakisH MakisH mentioned this pull request Mar 20, 2024
Closed
@Fujikawas Fujikawas merged commit 383e824 into develop Mar 21, 2024
1 check passed
@Fujikawas Fujikawas deleted the port-dunefem-tutorial branch March 21, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uekerman uekerman uekerman approved these changes

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees

@Fujikawas Fujikawas

Labels
None yet
Projects
None yet
Milestone
v202403.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Fujikawas @uekerman @IshaanDesai