-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document script plot-all-displacements #485
Conversation
The purpose of this script is to quickly be able to reproduce this plot: As far as I remember this is to some degree a regression test we do more or less regularly. We should at least somehow document how this plot is created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not delete this file and keep everything as it is for the distribution release:
- Comparing runs
{SU2, OpenFOAM, nutils} X {FEniCS, CalculiX, SU2}
is valuable. E.g. Change C3D8 elements to C3D8I elements in perpendicular-flap solid-calculix #250 - Running all 9 cases and storing them under unique names requires manual effort. I don't think we can easily improve this situation. Giving a name to the watchpoint file that includes the names of both participants (i.e.
openfoam-calculix.log
) breaks the black-box. The participant that is creating the watchpoint file does not know which participant sits on the other side. plot-displacements.sh
only allows to plot a single curve, not multiple. Extending this to support plotting of several is not trivial in this setting.
Possible todo: Documentation how to do the runs, store the results, and create the plot (manual effort mentioned under 2) could certainly be improved, but this is not really something critical for the distribution release.
I would keep the script and add 2 sentences of documentation to the case README. |
1c17b10
to
c2c3cc4
Compare
The comparison is valuable, the script as-it-is is mostly confusing. I restored the script and added documentation.
Automation could help, but that would be an overkill even for the system tests, as we need a system with all the solvers installed. We have that already in the VM, but even that would probably take hours to run. Reminder: we now have a cross-product of 3x7 (=21) solvers, with at least Nutils taking quite some time to run. Such automation would need to take fault tolerance into account.
It is. Compare: gnuplot -p << EOF
set grid
set title 'x-displacement of the flap tip'
set xlabel 'time [s]'
set ylabel 'x-displacement [m]'
+ set term pngcairo enhanced size 900,654
+ set output "images/tutorials-perpendicular-flap-displacement-all-watchpoints.png"
- plot "$1/precice-Solid-watchpoint-Flap-Tip.log" using 1:4 with lines title "$1"
+ plot "watchpoints/openfoam-calculix.log" using 1:4 with lines title "OpenFOAM-CalculiX", \
"watchpoints/openfoam-dealii.log" using 1:4 with lines title "OpenFOAM-deal.II", \
+ ...
EOF The difference is in the hard-coding of the filenames (just more than one arguments). The two
I added more documentation. We now essentially need to do the manual run of everything and update the picture. I will try to do that next week in the VM, in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. Rest looks ok.
Very use-case-specific, outdated, and trivial to reproduce from plot-displacement.sh