Solve structure inconsistency of partitioned-heat-conduction-direct
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fujikawas
changed the title
partitioned-heat-conduction-directpartitioned-heat-conduction-direct
MakisH
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Similarly to #496 (cc @IshaanDesai), the two solvers are almost identical, apart from configuration. This is fine for now, but ideally the solver could be merged into solver-nutils/heat.py and each case would read a short configuration file, or just a keyword dirichlet/neumann.
There was a problem hiding this comment.
Let's keep the duplication for now to move on, and we can make this nicer later.
MakisH
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to issue #461