Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DuMux 3.8 and update to DUNE 2.9.1 #87

Merged
merged 21 commits into from
Apr 23, 2024
Merged

Add DuMux 3.8 and update to DUNE 2.9.1 #87

merged 21 commits into from
Apr 23, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Apr 22, 2024

Closes #73.

Note that the two-scale-heat-conduction tutorial (micro-dumux/macro-dumux) does not build, probably due to the old compiler / STL:

Scanning dependencies of target micro_sim
[ 50%] Building CXX object appl/CMakeFiles/micro_sim.dir/micro_sim.cpp.o
/home/vagrant/tutorials/two-scale-heat-conduction/micro-dumux/appl/micro_sim.cpp:10:10: fatal error: numbers: No such file or directory
   10 | #include <numbers>
      |          ^~~~~~~~~
compilation terminated.

We could debug this further, but we will eventually update the baseline to Ubuntu 24.04. That would, however, need a lot of additional effort, as we already know of a few issues we will face (porting code_aster and maybe ASTE, if the VTK packages are still conflicting). cc @IshaanDesai

@MakisH MakisH requested a review from Fujikawas April 22, 2024 15:48
@MakisH MakisH changed the title WIP: Add DuMuX Add DuMuX Apr 23, 2024
@MakisH MakisH marked this pull request as ready for review April 23, 2024 09:46
@MakisH MakisH changed the title Add DuMuX Add DuMuX 3.8 and update to DUNE 2.9.1 Apr 23, 2024
@MakisH
Copy link
Member Author

MakisH commented Apr 23, 2024

@Fujikawas @mathiskelm this is ready for review, you might have objections.

@MakisH
Copy link
Member Author

MakisH commented Apr 23, 2024

@Fujikawas Now I get the Kokkos-related issue when building DuMuX also in the VM 🙈

GitHub Actions VM build log (see the raw logs)

Copy link

@mathiskelm mathiskelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the issue with the two-scale tutorial not working, this header is not required and could be removed. Can you easily check whether removing this include fixes the problem?

provisioning/install-dune.sh Outdated Show resolved Hide resolved
@MakisH
Copy link
Member Author

MakisH commented Apr 23, 2024

@Fujikawas Now I get the Kokkos-related issue when building DuMuX also in the VM 🙈

GitHub Actions VM build log (see the raw logs)

I worked around this by setting: -DCMAKE_DISABLE_FIND_PACKAGE_Kokkos=TRUE.

@MakisH MakisH changed the title Add DuMuX 3.8 and update to DUNE 2.9.1 Add DuMux 3.8 and update to DUNE 2.9.1 Apr 23, 2024
@MakisH MakisH requested a review from mathiskelm April 23, 2024 12:38
@MakisH MakisH marked this pull request as draft April 23, 2024 12:38
@MakisH MakisH marked this pull request as ready for review April 23, 2024 12:39
@MakisH MakisH marked this pull request as draft April 23, 2024 12:55
@MakisH MakisH marked this pull request as ready for review April 23, 2024 12:55
@MakisH MakisH marked this pull request as draft April 23, 2024 13:08
@MakisH MakisH marked this pull request as ready for review April 23, 2024 13:08
Hoping this helps get more consistent build starts
@MakisH MakisH marked this pull request as draft April 23, 2024 13:15
@MakisH MakisH marked this pull request as ready for review April 23, 2024 13:15
@MakisH MakisH marked this pull request as draft April 23, 2024 13:17
@MakisH MakisH marked this pull request as ready for review April 23, 2024 13:17
@MakisH
Copy link
Member Author

MakisH commented Apr 23, 2024

I don't know why, but I don't seem to be able to start a build of the VM on the GitHub runners anymore. I have already tried clearing the cache and changing to different runners.
I will trigger a clean full build on my local system and merge. Maybe waiting will also help.

The strange thing is that it sometimes works...

@MakisH MakisH merged commit de16019 into develop Apr 23, 2024
2 checks passed
@MakisH MakisH deleted the add-dumux branch April 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing DuMuX
3 participants