Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable use of manylinux wheeltags once again #1925

Merged
merged 3 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/pypi_modifiers/src/pypi_tags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ pub fn get_pypi_tags(
implementation_name,
// TODO: This might not be entirely correct..
(python_version.0 as u8, python_version.1 as u8),
false,
true,
// Should revisit this when this lands: https://github.com/conda-forge/python-feedstock/pull/679
false,
)
Expand Down
18 changes: 18 additions & 0 deletions tests/install_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -585,3 +585,21 @@ async fn test_old_lock_install() {
std::fs::read_to_string("tests/satisfiability/old_lock_file/pixi.lock").unwrap()
);
}

/// Only run this test on linux
#[tokio::test(flavor = "multi_thread", worker_threads = 1)]
#[serial]
#[cfg_attr(not(feature = "slow_integration_tests"), ignore)]
#[cfg(target_os = "linux")]
async fn test_many_linux_wheel_tag() {
let pixi = PixiControl::new().unwrap();
pixi.init().await.unwrap();

pixi.add("python==3.12.*").await.unwrap();
// We know that this package has many linux wheel tags for this version
pixi.add("gmsh==4.13.1")
.set_type(pixi::DependencyType::PypiDependency)
.with_install(true)
.await
.unwrap();
}
Loading