Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Error Boundary to Filter Config Modal #59

Merged
merged 1 commit into from
Dec 14, 2020
Merged

chore: Add Error Boundary to Filter Config Modal #59

merged 1 commit into from
Dec 14, 2020

Conversation

agatapst
Copy link

@agatapst agatapst commented Dec 14, 2020 •
edited
Loading

SUMMARY

Add Error boundary to Filter Config Modal.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

Verify manually.
Throw errors:
for Filter Config Modal, type throw new Error("test") i.e. in FilterConfigForm.tsx84 line

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

cc @villebro

@agatapst agatapst changed the title Add Error Boundary to Filter Config Modal chore: Add Error Boundary to Filter Config Modal Dec 14, 2020
@villebro villebro merged commit df6e745 into preset-io:native-filters-fast-follow Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agatapst @villebro