special case anchored-position for top-layer elements #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the positioning for an anchored position element, the current algorithm traverses the tree to find "positioned parents"; that is parents with a non-default
overflow
orposition
.This is acceptable for most elements, but native
<dialog>
and elements withpopover=
get reflected onto the:top-layer
element, which is adjacent to the document, and therefore layout should be calculated using the main viewport, not any overflow/position parents.This PR adds a check to special case such elements, by checking if the element is a
dialog
, or by checking if the:popover-open
psuedo class is active. Sadly there is no pseudo selector to detect whether or not an element is on the top layer, so we have to check for likely candidates instead.Fixes primer/view_components#2000