feat: add wildcard imports as exports #4976
Open
+78
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3ba43eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/342579 |
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've identified usage of wildcard imports downstream 👀 As a result, this PR adds these imports to named entry points that we have (and also creates a new one).
With these wildcard exports now coming from a named entry point, we can update dotcom to use these new exports before officially removing them ☠️
The full list of wildcard imports identified is at: https://github.com/primer/eslint-plugin-primer-react/blob/main/src/rules/no-wildcard-imports.js#L5
Changelog
New
@primer/react/test-helpersVisuallyHidden,VisuallyHiddenPropsto@primer/reactBetterCssPropertiesto@primer/reactBetterSystemStyleObjectto@primer/reactIssueLabelTokenPropsto@primer/reactLabelColorOptionsto@primer/reactuseIsomorphicLayoutEffectto@primer/reactuseProvidedRefOrCreateto@primer/reactActionListGroupedListProps,ActionListGroupProps,ActionListItemPropsto@primer/react/deprecatedDefaultFeatureFlagsto@primer/react/experimentalChanged
Removed
Rollout strategy