Revert leftover deprecated arguments from 1163 (#1188)

* Revert leftover deprecated arguments from 1163 * Create spotty-rats-hide.md * revert tests
primer · Jun 8, 2022 · fb7218a · fb7218a
1 parent 4601124
commit fb7218a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 41 deletions.
diff --git a/.changeset/spotty-rats-hide.md b/.changeset/spotty-rats-hide.md
@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Revert leftover deprecated arguments from 1163.
diff --git a/lib/rubocop/cop/primer/deprecated_arguments.rb b/lib/rubocop/cop/primer/deprecated_arguments.rb
@@ -33,22 +33,6 @@ class DeprecatedArguments < BaseCop
         # }
         #
         DEPRECATED = {
-          is_label_inline: {
-            true => nil,
-            false => nil
-          },
-          with_icon: {
-            true => nil,
-            false => nil
-          },
-          is_label_visible: {
-            false => "visually_hide_label: true",
-            true => "visually_hide_label: false"
-          },
-          is_clearable: {
-            false => "show_clear_button: false",
-            true => "show_clear_button: true"
-          },
           bg: {
             white: "bg: :primary",
             gray_light: "bg: :secondary",

diff --git a/test/rubocop/deprecated_arguments_test.rb b/test/rubocop/deprecated_arguments_test.rb
@@ -58,29 +58,4 @@ def test_deprecated_argument_with_nil_not_autocorrected
     assert_equal 1, cop.offenses.count
     refute cop.offenses.first.correctable?
   end
-
-  def test_supports_boolean_values
-    investigate(cop, <<-RUBY)
-      Primer::Beta::AutoComplete.new(is_label_visible: false)
-    RUBY
-
-    assert_equal 1, cop.offenses.count
-    assert_equal "Primer::Beta::AutoComplete.new(visually_hide_label: true)", cop.offenses.first.corrector.rewrite.strip
-  end
-
-  def test_identifies_is_label_inline
-    investigate(cop, <<-RUBY)
-      Primer::Beta::AutoComplete.new(label_text: "User", is_label_inline: true)
-    RUBY
-
-    assert_equal 1, cop.offenses.count
-  end
-
-  def test_identifies_with_icon
-    investigate(cop, <<-RUBY)
-      Primer::Beta::AutoComplete.new(label_text: "User", with_icon: true)
-    RUBY
-
-    assert_equal 1, cop.offenses.count
-  end
 end