move Primer::BorderBoxComponent and Header, to Beta::BorderBox #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b425f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ve-border-box-to-beta
54 tasks
mxriverlynn
changed the title
camertron
reviewed
Aug 2, 2022
| # `BorderBox::Header` is used inside `BorderBox` to render its header slot. | ||
| # | ||
| # @accessibility When using `header.title`, set `tag` to one of `h1`, `h2`, `h3`, etc. based on what is appropriate for the page context. <%= link_to_heading_practices %> | ||
| class Header < Primer::Component | ||
| status :beta |
There was a problem hiding this comment.
I believe only top-level components have statuses?
|
@mxriverlynn oh also, please add a changeset 😄 |
camertron
approved these changes
Aug 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split from #676
this PR renames the
Primer::BorderBoxComponentand moves it into the beta folder, along with it'sHeadersub-component.Primer::BorderBoxComponent->Primer::Beta::BorderBoxPrimer::BorderBoxComponent::Header->Primer::Beta::BorderBox::Headerit also updates all of the tests, documentation, stories, links, and references to these components. and it re-creates the original BorderBoxComponent as a deprecated component, inheriting from the beta version.
files to note when reviewing
there are a lot of files updated in this PR, due to the component and sub-component both moving. these are the files you should pay most attention to, while reviewing:
screenshots
updated documentation navigation and url:
updated stories component tree and url:
