Only register click handler once #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
🦋 Changeset detectedLatest commit: dae2bc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
javascript
koddsson
force-pushed
the
make-nested-dialogs-work
branch
from
d7308b3
to
dae2bc7
Compare
jonrohan
approved these changes
Oct 11, 2022
| @@ -83,5 +84,6 @@ | |||
| "tslib": "^2.4.0", | |||
| "typescript": "^4.7.4" | |||
| }, | |||
| "prettier": "@github/prettier-config" | |||
| "prettier": "@github/prettier-config", | |||
| "browserslist": "extends @github/browserslist-config" | |||
There was a problem hiding this comment.
There's a browserslistrc file I added recently, could you delete that in favor of this one?
Merged
jonrohan
pushed a commit
that referenced
this pull request
Oct 11, 2022
* Update `eslint-plugin-github` Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com> * Use `@github/browserlist-config` Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com> * Update caniuse-lite db Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com> * Fix shadowed variable Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com> * Only register click handler once * changeset Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
<modal-dialog>registers a global event handler each time it connects to the DOM. We actually just want one global event handler so that we don't open or close multiple dialogs when clicking around on the page.This PR makes sure we only register the event handler once by using a function reference instead of a inlined function for the click handler.
Closes #1366 (again :)