Use URL helpers in previews that interact with the server-side #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7bbb3bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
temporarily deployed
to
review-pr-1693
GitHub Actions
Inactive
|
Nice! I think we have similar problems with the autocomplete component |
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
changed the title
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
It doesn't seem to work on http://primer-view-components-preview-1693.eastus.azurecontainer.io/ |
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
force-pushed
the
fix_toggle_switch_previews
branch
from
173f913
to
7bbb3bf
Compare
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jonrohan
approved these changes
Dec 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of our previews don't work in the prod Lookbook because the URLs are hard-coded and only work in dev.
Integration
No.
Merge checklist
Added/updated testsAdded/updated documentation