Toggle switch error messages #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Render a validation element and fill it in or hide it depending on the response from the server.
This looks a lot nicer when there is also a caption and/or validation message after the label.
This will occupy the same amount of space regardless of if we are showing one of the status octicons (loading or error) to prevent excessive layout jumping on the page. Also adds a gap style to the flexbox container to keep a little distance from the label/caption/validation message.
🦋 Changeset detectedLatest commit: 4c1d06a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
css
|
…r/view_components into neall/toggle-switch-error-messages
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
temporarily deployed
to
review-pr-1760
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Visual differences are expected. |
camertron
changed the title
|
Should the octagon be nudged 1-2 pixels upwards, perhaps? 1px up: |
camertron
temporarily deployed
to
review-pr-1760
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
reviewed
Jan 17, 2023
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
jonrohan
approved these changes
Jan 17, 2023
…r/view_components into neall/toggle-switch-error-messages
camertron
had a problem deploying
to
review-pr-1760
GitHub Actions
Error
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@neall and I have been pairing on getting error messages to display properly when a toggle switch request fails. This is the result.
Integration
No
Merge checklist
- [ ] Added/updated documentation