Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group support to ActionMenu #2340

Merged
merged 15 commits into from
Nov 21, 2023
Merged

Add group support to ActionMenu #2340

merged 15 commits into from
Nov 21, 2023

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Nov 1, 2023

What are you trying to accomplish?

This PR adds group support to ActionMenu. Groups are already supported by sister component NavList, as well as by the React version of ActionMenu.

Screenshots

Groups Groups and items together
A screenshot of an open ActionMenu with three groups. The invoker button is labeled 'Favorite character.' The groups are labeled 'Battlestar Galactica,' 'Star Trek,' and 'Star Wars.' Each group contains four characters from their respective series. A screenshot of an open ActionMenu. The invoker button is labeled 'Meal preference' and there are three sections. The first is a single item without a header labeled 'Meat option.' The second is a group with a header that reads 'Vegetarian options.' There are three items in this group, 'Grilled portobello mushroom,' 'Polenta,' and 'Seitan.' The last section contains a single item without a header labeled 'Fish option.'

Integration

No changes necessary in production - I was able to work groups in without changing the component's public interface.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Nov 1, 2023

🦋 Changeset detected

Latest commit: 568f2ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron temporarily deployed to preview November 1, 2023 01:46 — with GitHub Actions Inactive
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Nov 1, 2023
@camertron camertron changed the title WIP Add group support to ActionMenu Nov 1, 2023
Copy link
Contributor

github-actions bot commented Nov 10, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@camertron camertron marked this pull request as ready for review November 17, 2023 22:09
@camertron camertron requested review from a team, keithamus and jonrohan and removed request for keithamus November 17, 2023 22:09
@camertron camertron merged commit b8d0540 into main Nov 21, 2023
30 checks passed
@camertron camertron deleted the action_menu_groups branch November 21, 2023 22:56
@primer primer bot mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants