Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to attach action menus to button group buttons #2607

Merged
merged 16 commits into from
Feb 14, 2024

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

This PR adds a new with_menu_button slot to Primer::Beta::ButtonGroup in response to a question in Slack.

Screenshots

A screenshot of a Lookbook preview showing a button group with two buttons. An ActionMenu appears under the second, right-most button.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I elected to add a third option to the polymorphic button slot.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: 2bd86d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 13, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@camertron camertron marked this pull request as ready for review February 14, 2024 19:10
@camertron camertron requested review from a team and jonrohan February 14, 2024 19:10
@jonrohan
Copy link
Member

Ooo, just what I was wanting.

the-simpsons-waiting-gif

…l.erb

Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
@camertron camertron merged commit 1cf14e5 into main Feb 14, 2024
30 checks passed
@camertron camertron deleted the button_group_menu branch February 14, 2024 21:59
@primer primer bot mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants